[GraphBolt] Allow using multiple processes for GraphBolt partition co… #7497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
Rhett-Ying
reviewed
Jul 2, 2024
| @@ -7,6 +7,7 @@ | |||
| import time | |||
|
|
|||
| import numpy as np | |||
| from joblib import Parallel, delayed | |||
There was a problem hiding this comment.
could we achieve parallelism with standard module from python such as https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.ProcessPoolExecutor instead of adding new dependency?
There was a problem hiding this comment.
Sure, I'll switch to using multiprocessing. I think joblib is pulled in with other DGL deps, but it's not explicitly added yeah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nversion
Description
Checklist
Please feel free to remove inapplicable items for your PR.
Changes